find the corresponding english page to list languages #2666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
force-pushed
the
lang-dropdown-ru-scala-book
branch
from
524cec7 to
3aec13d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves an issue that if the first alphabetically ordered page in a multipage-overview is not translated, then that language will not appear in the language dropdown.
Instead, we now find the english page that has the same
id(read as language-independent URL) to source the translations for that individual page, rather than for the whole overviewThis problem manifested in the
rutranslation of the scala 3 book, which does not have a translation for_overviews/scala3-book/ca-context-bounds.md, i.e. the first alphabetically ordered English page in the collection. See the change here:before:
after:
